Skip to content

Conversation

@CamSoper
Copy link
Contributor

@CamSoper CamSoper commented Sep 23, 2025

  • Removed rule about every sentence/phrase being on a new line. Nobody actually does that anywhere in this repo, so why was it in the style guide?
  • Added conditional to PR review workflow to filter out automated PRs from pulumi-bot. Pulumi Bot ain't reading them, so we shouldn't pay for them.
  • Tweaked PR review prompt for both Claude and Copilot for better results.

@claude
Copy link
Contributor

claude bot commented Sep 23, 2025

Review Feedback

This PR appropriately removes the semantic line break rule that was inconsistently followed. The changes are well-structured and improve the guidelines. I have a few observations:

AGENTS.md:51 - The change from "semantic line breaks" to "Standard paragraph formatting" is accurate and aligns with actual repository practices.

STYLE-GUIDE.md:32-33 - The new heading punctuation and spacing rules are valuable additions that weren't explicitly covered before.

STYLE-GUIDE.md:67-68 - Good clarification that text should wrap naturally instead of using artificial line breaks.

Consistency check: The changes maintain consistency between AGENTS.md and STYLE-GUIDE.md, with both now advocating for standard paragraph formatting.

Minor formatting note: All changes follow the existing style conventions (proper spacing, formatting) and end with newlines as required.

The changes are clear, technically accurate, and resolve a real inconsistency between documented rules and actual practice. Approved

@pulumi-bot
Copy link
Collaborator

@CamSoper CamSoper changed the title Update Markdown formatting rules in AGENTS.md and STYLE-GUIDE.md Misc. updates for agents/automated PR reviews Sep 23, 2025
@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@CamSoper CamSoper merged commit bfa3d02 into master Sep 23, 2025
8 checks passed
@CamSoper CamSoper deleted the fix-break-rule branch September 23, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants